-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get diagnostics of all devices in ViCare account #102218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, can you take a look?
Hint: pytest ./tests/components/vicare --snapshot-update
and commit the changes
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Your tests are failing :) |
@joostlek there seems to be an issue with the coverage upload. What can I do about it? |
The coverage upload is flaky, but we know when we can ignore it and when we want to see it :) |
Breaking change
Proposed change
With this PR the diagnostic information contain all ViCare devices linked to the configured account.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: