Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get diagnostics of all devices in ViCare account #102218

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Oct 18, 2023

Breaking change

Proposed change

With this PR the diagnostic information contain all ViCare devices linked to the configured account.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, can you take a look?

Hint: pytest ./tests/components/vicare --snapshot-update and commit the changes

@home-assistant home-assistant bot marked this pull request as draft October 18, 2023 11:26
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@CFenner CFenner marked this pull request as ready for review October 18, 2023 11:31
@CFenner CFenner marked this pull request as draft October 18, 2023 11:31
@joostlek
Copy link
Member

Your tests are failing :)

@CFenner
Copy link
Contributor Author

CFenner commented Oct 18, 2023

@joostlek there seems to be an issue with the coverage upload. What can I do about it?

@joostlek
Copy link
Member

The coverage upload is flaky, but we know when we can ignore it and when we want to see it :)

@CFenner CFenner marked this pull request as ready for review October 18, 2023 15:27
@joostlek joostlek merged commit eee294d into home-assistant:dev Oct 18, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants